Skip to content

docs(object_store): add Tencent Cloud COS and GooseFS configuration#7151

Open
XuQianJin-Stars wants to merge 1 commit into
lance-format:mainfrom
XuQianJin-Stars:docs/add-cos-goosefs-config
Open

docs(object_store): add Tencent Cloud COS and GooseFS configuration#7151
XuQianJin-Stars wants to merge 1 commit into
lance-format:mainfrom
XuQianJin-Stars:docs/add-cos-goosefs-config

Conversation

@XuQianJin-Stars

@XuQianJin-Stars XuQianJin-Stars commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Files changed

File Change
docs/src/guide/object_store.md +169 / -0

Verification

  • Markdown only; no Rust / Python / Java source touched, so no cargo / pytest / mvn runs are required.
  • Code samples were cross-checked against the actual Rust / Java public API (DatasetBuilder::with_storage_options, OpenDatasetBuilder.readOptions, ReadOptions.Builder.setStorageOptions) and against the integration test rust/lance-io/tests/goosefs_integration.rs.
  • The new tabbed code blocks rely on the pymdownx.tabbed extension, which is already enabled in the project's MkDocs configuration.

Notes for reviewers

  • The COS section is intentionally written as a thin layer on top of the existing S3 docs (it just specifies the right endpoint / region / virtual-hosted style for Tencent Cloud) — no new options were invented.
  • All comments and prose are in English to match the rest of the docs.
Clipboard_Screenshot_1780912681

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added A-docs Documentation documentation Improvements or additions to documentation labels Jun 8, 2026
@XuQianJin-Stars XuQianJin-Stars changed the title docs(object_store): add Tencent Cloud COS and GooseFS configuration guides docs(object_store): add Tencent Cloud COS and GooseFS configuration Jun 8, 2026

@yanghua yanghua left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

let (store, path) = ObjectStore::from_uri(uri).await?;

// Read / write through the object_store API
store.inner.put(&path, bytes::Bytes::from("hello").into()).await?;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be b"hello"[..].into().

let uri = "goosefs://10.0.0.1:9200/lance-test/lance-io";
let (store, path) = ObjectStore::from_uri(uri).await?;

// Read / write through the object_store API

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

object_store::ObjectStore

| `tos_secret_access_key` | Secret access key used for TOS authentication. Optional if credentials are provided by environment. |
| `tos_security_token` | Security token for temporary credentials. Optional. |

## Tencent Cloud COS Configuration

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have no description of cargo feature like goosefs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docs Documentation documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants