Skip to content

ci: pin license-header-checker to fix flaky install step#7142

Open
wombatu-kun wants to merge 1 commit into
lance-format:mainfrom
wombatu-kun:ci/pin-license-header-checker
Open

ci: pin license-header-checker to fix flaky install step#7142
wombatu-kun wants to merge 1 commit into
lance-format:mainfrom
wombatu-kun:ci/pin-license-header-checker

Conversation

@wombatu-kun
Copy link
Copy Markdown
Contributor

The license-header-check job installs the checker via the upstream install.sh with no pinned tag, so it resolves "latest" by fetching the GitHub releases page and parsing tag_name. That fetch intermittently returns empty and fails the job with unable to find '', unrelated to any PR's contents.

Previous failed run (the install step, not a header violation): https://github.com/lance-format/lance/actions/runs/27094024188/job/79962732768

Reading the upstream install.sh shows that passing a pinned tag would not help - github_release() still fetches the releases page to resolve the tag. So this pins to v1.5.0 and downloads the release asset directly from the CDN, removing the dynamic tag/JSON lookup entirely. The job runs only on ubuntu-latest, so the linux_amd64 asset is used.

The license-header-check job installs the checker via the upstream install.sh with no pinned tag, so it resolves "latest" by fetching the GitHub releases page and parsing tag_name. That fetch intermittently returns empty and fails the job with "unable to find ''", unrelated to any PR's contents. Pin to v1.5.0 and download the release asset directly from the CDN, removing the dynamic tag lookup. The job runs only on ubuntu-latest, so the linux_amd64 asset is used.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added A-ci CI / build workflows ci Github Action or Test issues labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci CI / build workflows ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant