ci: pin license-header-checker to fix flaky install step#7142
Open
wombatu-kun wants to merge 1 commit into
Open
ci: pin license-header-checker to fix flaky install step#7142wombatu-kun wants to merge 1 commit into
wombatu-kun wants to merge 1 commit into
Conversation
The license-header-check job installs the checker via the upstream install.sh with no pinned tag, so it resolves "latest" by fetching the GitHub releases page and parsing tag_name. That fetch intermittently returns empty and fails the job with "unable to find ''", unrelated to any PR's contents. Pin to v1.5.0 and download the release asset directly from the CDN, removing the dynamic tag lookup. The job runs only on ubuntu-latest, so the linux_amd64 asset is used. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
license-header-checkjob installs the checker via the upstreaminstall.shwith no pinned tag, so it resolves "latest" by fetching the GitHub releases page and parsingtag_name. That fetch intermittently returns empty and fails the job withunable to find '', unrelated to any PR's contents.Previous failed run (the install step, not a header violation): https://github.com/lance-format/lance/actions/runs/27094024188/job/79962732768
Reading the upstream
install.shshows that passing a pinned tag would not help -github_release()still fetches the releases page to resolve the tag. So this pins tov1.5.0and downloads the release asset directly from the CDN, removing the dynamic tag/JSON lookup entirely. The job runs only onubuntu-latest, so thelinux_amd64asset is used.