fix(index): invalidate stale index cache entries after index replacement#7094
Open
geserdugarov wants to merge 2 commits into
Open
fix(index): invalidate stale index cache entries after index replacement#7094geserdugarov wants to merge 2 commits into
geserdugarov wants to merge 2 commits into
Conversation
Contributor
Author
|
@Xuanwo, @wjones127, hi! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CreateIndexcommits can retire existing index metadata, for example whenoptimize_indices(...retrain...)replaces an IVF index with a new UUID. If the old index had been prewarmed, the session index cache could still hold root entries and IVF partition entries for the removed UUID.A later read in the same session could then observe stale cached index state that no longer matches the manifest. This clears cache entries for removed index UUIDs after the commit succeeds.
Changes
LanceCacheviainvalidate_with_keyandinvalidate_unsized_with_key.CacheBackendwithinvalidate_entryand implement it for the Moka backend and existing serializing test backends.Operation::CreateIndexcommits, invalidate cache entries for each removed index:uuid/uuid-fri_uuid/entries when a fragment-reuse index is activeremoved_indices, so conflict resolution invalidates the indices actually retired by the committed manifest.Notes
Tests
optimize_indices, and verifies the removed index UUID no longer has cached root or partition entries.