test: Add REST tests for explicitly-retired / non-active lifecycle records#106
Merged
Merged
Conversation
Collaborator
|
This currently fails CI in clippy because the new tests do not match the current API:
|
beinan
approved these changes
Jun 27, 2026
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Adds two REST-layer search tests covering lifecycle visibility (Fixes lance-format#105): - search_respects_explicit_retirement: an update patch stamping retired_at hides the successor from default search; include_retired surfaces it. - search_respects_non_active_lifecycle_status: moving a record to a hidden lifecycle status ("superseded") hides it; include_retired surfaces it. Addresses review feedback from @dcfocus and rebases onto current main to resolve the merge conflict: - RecordPatchDto.retired_at is Option<DateTime<Utc>> -> Some(Utc::now()). - RecordPatchDto.lifecycle_status is Option<String>; drop the nonexistent crate::model::LifecycleStatus and use a hidden status string. - "contradicted" is treated as visible by is_hidden_by_lifecycle, so use "superseded" to exercise the non-active hidden branch. - Use the shared CTX constant and imported update_record helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105.
Problem Statement:
Explicit retirement (
retired_at) and non-active lifecycle status (e.g.Contradicted) behaviors were lacking REST layer test coverage for thesearchendpoint.Technical Solution:
search_respects_explicit_retirementtosearch.rstest suite.search_respects_non_active_lifecycle_statustosearch.rstest suite.include_retired = trueis passed.Testing Performed:
cargo fmt.Related Issue:
Resolves #105