fix: close remaining FFI panic boundary gaps - #65
Merged
Conversation
u70b3
marked this pull request as ready for review
August 26, 2026 13:32
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The panic-containment change remains well-grounded, and the previous poll-waker lifetime blocker is fixed. Scanner close now cancels pending registrations and waits for active callbacks before freeing the scanner, with registration serialized against retirement. The public lifetime/no-reentry contract and focused regressions cover retained-waker cancellation and active-callback quiescence.
jja725
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #62 and #61. This addresses the remaining
lance_dataset_take/take_rowsreview note and the additional FFI boundary gaps found in a full post-merge audit.Summary
panic=abortbuildstake/take_rowsArrow readers, preflight schemas, sanitize deferred errors, and contain release-time panicsValidation
cargo fmt --checkcargo check --all-targets --offlinecargo clippy --all-targets --offline -- -D warningscargo test --offline(346 tests passed)cargo test --test compile_and_run_test --offline -- --ignored(C and C++)cargo rustdoc --lib --offline -- -D warningscargo check --release --all-targets --offlinecargo rustc --lib --offline -- -C panic=abort(expected compile-time rejection)No dependency or
Cargo.lockchanges.