-
Notifications
You must be signed in to change notification settings - Fork 18
Document sysctl tuning for QUIC UDP buffer sizes #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,13 @@ make run-devnet | |
| This generates fresh genesis files and starts all configured clients with metrics enabled. | ||
| Press `Ctrl+C` to stop all nodes. | ||
|
|
||
| > **Note:** On Linux, QUIC performance benefits from larger UDP receive buffers. If you see warnings about buffer sizes, increase the kernel limit: | ||
| > ```sh | ||
| > sudo sysctl -w net.core.rmem_max=7340032 | ||
| > sudo sysctl -w net.core.wmem_max=7340032 | ||
| > ``` | ||
| > To persist across reboots, add to `/etc/sysctl.conf`. For Docker, pass `--sysctl net.core.rmem_max=7340032 --sysctl net.core.wmem_max=7340032`. | ||
|
Comment on lines
+43
to
+48
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Prompt To Fix With AIThis is a comment left during a code review.
Path: README.md
Line: 43-48
Comment:
**Docker `--sysctl` flag not applicable to Compose-based devnet**
`make run-devnet` uses `lean-quickstart`, which is Docker Compose based. The `--sysctl` flag shown applies to `docker run`; for Compose deployments the equivalent is a `sysctls:` key in the service definition. Users trying to apply this hint to the devnet may be confused. Consider clarifying that the Docker note applies to standalone `docker run` invocations, or point to modifying the Compose file for the devnet case.
How can I resolve this? If you propose a fix, please make it concise. |
||
|
|
||
| > **Important:** When running nodes manually (outside `make run-devnet`), at least one node must be started with `--is-aggregator` for attestations to be aggregated and included in blocks. Without this flag, the network will produce blocks but never finalize. | ||
|
|
||
| For custom devnet configurations, go to `lean-quickstart/local-devnet/genesis/validator-config.yaml` and edit the file before running the command above. See `lean-quickstart`'s documentation for more details on how to configure the devnet. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/etc/sysctl.confnote omits apply-without-reboot stepThe note says "add to
/etc/sysctl.conf" but doesn't show what to write or how to activate it without rebooting. Users will likely need to runsudo sysctl -pto apply immediately. A self-contained example would be clearer:Prompt To Fix With AI