Skip to content

fix(lint): resolve staticcheck issues and improve code quality#2941

Merged
aldas merged 6 commits intolabstack:masterfrom
itsllyaz:fix/lint-staticcheck
Apr 7, 2026
Merged

fix(lint): resolve staticcheck issues and improve code quality#2941
aldas merged 6 commits intolabstack:masterfrom
itsllyaz:fix/lint-staticcheck

Conversation

@itsllyaz
Copy link
Copy Markdown
Contributor

@itsllyaz itsllyaz commented Apr 6, 2026

This PR resolves several staticcheck lint issues, got the report from golangci-lint.

Changes

  • Applied De Morgan’s law to simplify boolean expressions
  • Replaced fmt.Sprintf with fmt.Fprintf to avoid unnecessary allocations
  • Removed redundant embedded field access
  • Improved overall code readability and idiomatic Go usage

Impact

  • No functional changes
  • Minor performance improvements
  • Cleaner and more maintainable code

Notes

All changes were verified with:

golangci-lint run

there is no remaining lint issues.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (22e4b71) to head (b1d350e).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2941      +/-   ##
==========================================
- Coverage   93.07%   93.07%   -0.01%     
==========================================
  Files          43       43              
  Lines        4506     4503       -3     
==========================================
- Hits         4194     4191       -3     
  Misses        195      195              
  Partials      117      117              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run go fmt

Copy link
Copy Markdown
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 0143b9d into labstack:master Apr 7, 2026
10 checks passed
@aldas
Copy link
Copy Markdown
Contributor

aldas commented Apr 7, 2026

Thanks @itsllyaz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants