refactor(Scripts): extract Xcode report policy - #284
Open
kyleve wants to merge 7 commits into
Open
Conversation
kyleve
commented
Aug 17, 2026
|
|
||
| def _parse_problems(bundles: Mapping[str, Mapping[str, object]]) -> list[str]: | ||
| problems = [] | ||
| if len(bundles) < 15: |
Owner
Author
There was a problem hiding this comment.
Review focus: this deliberately preserves the shell implementation’s fail-closed bundle floor instead of introducing a new target catalog in this extraction. The direct tests cover both rejection and dependency closure; a later manifest-format change must keep under-selection observable.
kyleve
force-pushed
the
codex/extract-xcode-script-python
branch
from
August 19, 2026 02:42
a573993 to
92ea609
Compare
kyleve
force-pushed
the
codex/extract-xcode-script-python
branch
from
August 19, 2026 03:22
402ac57 to
95d4d3a
Compare
kyleve
force-pushed
the
codex/extract-xcode-script-python
branch
from
August 19, 2026 04:07
d856f46 to
3739353
Compare
kyleve
force-pushed
the
codex/extract-xcode-script-python
branch
from
August 19, 2026 04:09
3739353 to
56c6dde
Compare
kyleve
force-pushed
the
codex/extract-xcode-script-python
branch
from
August 19, 2026 04:20
c0b358b to
e39b463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test,profile, andflakyinto importable modules underTools/Why
The high-risk untested surface was structured parsing and reporting policy, not the public shell bootstrap. Extracting those pieces provides direct tests and reuse without recreating the discarded Swift command framework.
Design decisions
xcode_results.pyowns xcresult traversal only; it does not invoke processes.snapshot_reports.pyis shared bytestandprofile; thresholds and failure semantics remain command-specific.test_runner.py,profile_results.py, andflaky_results.pystay separate so affected-scope, profiling, and flake policies cannot blur together../testkeeps TTY redraws, captured-CI heartbeats, cached denominators, image progress, and zero-test failure.Compatibility
Public paths, flags, scope-selector precedence, output streams, defaults, and exit policies match
main.Adversarial coverage
Testing
./test StuffCoreTests(real Xcode smoke, passed)./profile --tests-only --no-snapshots(2,119 tests parsed, passed at stack tip)./flaky --suite-runs 1 --iterations 2 --no-update(2,120 tests observed, passed at stack tip)Stack
Second PR; based on #283.