[cinder-csi-plugin] Allow setting parameters on chart-managed StorageClasses - #3173
[cinder-csi-plugin] Allow setting parameters on chart-managed StorageClasses#3173locker95 wants to merge 1 commit into
Conversation
…Classes
Add optional storageClass.delete.parameters and
storageClass.retain.parameters values to the Helm chart, rendered into
the respective StorageClass. Defaults to {}, rendered output is
unchanged when unset.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @locker95. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The Helm chart's built-in
csi-cinder-sc-delete/csi-cinder-sc-retainStorageClasses currently cannot carry anyparameters(e.g.availabilityortype), forcing users to disable them and maintain custom classes just to set a parameter. This adds optionalstorageClass.delete.parametersandstorageClass.retain.parametersvalues that are rendered into the respective StorageClass. They default to{}, and the rendered output is byte-identical to the previous chart when unset.Which issue this PR fixes:
fixes #1980
Special notes for reviewers:
Picks up where the closed #2434 left off (thanks @sakshi-1505). Verified with
helm template: output is unchanged with default values, and theparameters:block renders correctly when set;helm lintpasses. Chart version bumped to 2.36.3, matching the patch-bump convention of recent chart changes (#3152, #3078). This PR was written in part with the assistance of generative AI.Release note: