Skip to content

[cinder-csi-plugin] Allow setting parameters on chart-managed StorageClasses - #3173

Open
locker95 wants to merge 1 commit into
kubernetes:masterfrom
locker95:chart-cinder-sc-parameters
Open

[cinder-csi-plugin] Allow setting parameters on chart-managed StorageClasses#3173
locker95 wants to merge 1 commit into
kubernetes:masterfrom
locker95:chart-cinder-sc-parameters

Conversation

@locker95

@locker95 locker95 commented Sep 1, 2026

Copy link
Copy Markdown

What this PR does / why we need it:

The Helm chart's built-in csi-cinder-sc-delete / csi-cinder-sc-retain StorageClasses currently cannot carry any parameters (e.g. availability or type), forcing users to disable them and maintain custom classes just to set a parameter. This adds optional storageClass.delete.parameters and storageClass.retain.parameters values that are rendered into the respective StorageClass. They default to {}, and the rendered output is byte-identical to the previous chart when unset.

Which issue this PR fixes:

fixes #1980

Special notes for reviewers:

Picks up where the closed #2434 left off (thanks @sakshi-1505). Verified with helm template: output is unchanged with default values, and the parameters: block renders correctly when set; helm lint passes. Chart version bumped to 2.36.3, matching the patch-bump convention of recent chart changes (#3152, #3078). This PR was written in part with the assistance of generative AI.

Release note:

[cinder-csi-plugin] The Helm chart now supports setting `parameters` on the chart-managed delete/retain StorageClasses via `storageClass.<reclaim-policy>.parameters`.

…Classes

Add optional storageClass.delete.parameters and
storageClass.retain.parameters values to the Helm chart, rendered into
the respective StorageClass. Defaults to {}, rendered output is
unchanged when unset.
@kubernetes-prow kubernetes-prow Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @locker95. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin] Allow StorageClass parameters to be set in Helm chart

1 participant