[occm] Reduce ClusterRole scope - #3165
Open
stephenfin wants to merge 3 commits into
Open
Conversation
OCCM does not need to create or delete nodes Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
OCCM does not need this access. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
OCCM does not query Kubernetes secrets via the Kubernetes API in any of
its controllers. The only secret is needs access to is the
'cloud-config' secret mounted as a volume into the container. This
exists in the 'kube-system' namespace for standard manifests and the
release namespace when deployed via Helm. Therefore it's unnecessary to
grand cluster-wide get, list and watch access to all secrets via the
system:cloud-controller-manager ClusterRole.
Fix this by introducing a new
'system:cloud-controller-manager:secret-reader' Role in the standard
manifests and a '{{ .Values.clusterRoleName }}:secret-reader' Role in
the Helm charts.
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
kubernetes-prow
Bot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A collection of 3 changes, all intended to reduce the cluster-wide access granted by the
system:cloud-controller-managerClusterRole.[occm] Limit verbs for node access: OCCM does not need to create or delete nodes[occm] Prevent access to PVs: OCCM does not need access to PVs[occm] Add new Role for secrets: OCCM does not need cluster-wide secret access. It only needs access to the configuration secret (kube-system / cloud-configif using the standard manifests).Which issue this PR fixes(if applicable):
(none)
Special notes for reviewers:
Release note: