Skip to content

add options to tune concurrency, qps and burst#287

Open
ajaysundark wants to merge 3 commits into
kubernetes-sigs:mainfrom
ajaysundark:runtime-tuning
Open

add options to tune concurrency, qps and burst#287
ajaysundark wants to merge 3 commits into
kubernetes-sigs:mainfrom
ajaysundark:runtime-tuning

Conversation

@ajaysundark

Copy link
Copy Markdown
Contributor

Description

Add flags to the controller to tune controller-runtime knobs for scalability

Related Issue

None

Type of Change

/kind feature

Testing

Manual test runs

Checklist

  • make test passes
  • make lint passes

Does this PR introduce a user-facing change?

Yes, adds command-flags to tune concurrency, qps and burst -- https://cluster-api.sigs.k8s.io/developer/core/tuning#runtime-tuning-options

Relevant for our ongoing scalability work.

add new commandline-flags for tuning concurrency, qps and burst limits

@kubernetes-prow kubernetes-prow Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 3, 2026
@netlify

netlify Bot commented Jul 3, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit ce835cc
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a4d413d484616000800b17f
😎 Deploy Preview https://deploy-preview-287--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaysundark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2026
@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2026
Comment thread cmd/main.go Outdated
Comment thread cmd/main.go Outdated
Comment thread cmd/main.go
@vitorfloriano

vitorfloriano commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

I took this branch for a spin and verified that the tuning works.

I ran a manual test with a 1000-node kwok cluster without any parameters and NRC added all the taints in about 2m55s:

image

The same manual test with --node-concurrent-reconciles 20 --kube-api-burst 1000 --kube-api-qps 50** is performed in 1m21s (about half the time w/o any tuning):

image

I'm still learning how to query Prometheus, but I think I got this right.

**Just picked these numbers randomly.

@ajaysundark

Copy link
Copy Markdown
Contributor Author

@Karthik-K-N @vitorfloriano addressed your comments, ptal when you are available.

@ajaysundark

Copy link
Copy Markdown
Contributor Author

/retest

@ajaysundark ajaysundark requested a review from Karthik-K-N July 7, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants