🌱 Bump to golangci-lint v2.13.1 - #3580
Open
dongjiang1989 wants to merge 2 commits into
Open
Conversation
…rnings - Upgrade golangci-lint from v2.12.2 to v2.13.1 in CI workflow - Use strings.Cut instead of strings.SplitN in gomodcheck - Replace deprecated Requeue:true with RequeueAfter in examples/crd - Use metav1.NewFieldsV1() instead of deprecated Raw field in fake client tests - Add nolint:staticcheck for intentional use of deprecated Requeue field in controller tests Signed-off-by: dongjiang <dongjiang1989@126.com>
kubernetes-prow
Bot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dongjiang1989 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
size/S
dongjiang1989
changed the title
…3.1) Signed-off-by: dongjiang <dongjiang1989@126.com>
kubernetes-prow
Bot
added
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
ref: kubernetes-sigs/controller-tools#1469
strings.Cutinstead ofstrings.SplitNin gomodcheckfmtappendffrom modernize disable list (removed in v2.13.1)Requeue: truewithRequeueAfterin examplesmetav1.NewFieldsV1()instead of deprecatedRawfield in tests//nolint:staticcheckfor intentional deprecatedRequeueusage in controller testsWhy?
Keep CI tooling current and resolve new deprecation warnings introduced by the linter upgrade.