🐛 pass manager logger to leader elector via context - #3576
Conversation
Signed-off-by: Hüseyin Demirdilek <hueseyin.demirdilek@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: demirdilek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @demirdilek! |
|
Hi @demirdilek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Passes the manager logger with name
leaderelectionvia context toleaderElector.Run(), ensuring contextual logging inclient-gouses the configured manager logger instead of falling back to the global logger.Which issue(s) this PR fixes:
Fixes #2656
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?: