fix(ci): pass release notes by file, not shell interpolation - #4
Merged
Conversation
The first real release published notes with every `code span` and the fenced code
block silently removed: `${{ steps.notes.outputs.body }}` interpolates the text
into the shell script, so bash treats the backticks as command substitution and
executes them.
The preamble is already on disk, so use --notes-file and drop the GITHUB_OUTPUT
round-trip. The generator itself was correct — the dry-run summaries rendered
properly, which isolated the fault to the publishing step.
Same fix applied across all five repositories.
The first real release tagged v0.2.1 but published no versioned image. A tag pushed with GITHUB_TOKEN does not trigger other workflows — GitHub suppresses that to prevent recursion — so docker.yml never fired despite its `tags: ["v*"]` trigger. That matters beyond the missing tag: kube-workspaces/deploy's release workflow refuses to release unless a matching image exists for all four components, so the whole chain would stall. Dispatch the build explicitly once the release is created. The v0.2.1 images were built by hand; from v0.2.2 onward this is unattended.
Actions evaluates expressions everywhere in a workflow file, including inside comments. The placeholder in the previous commit's explanatory comment was not valid expression syntax, so the file failed to parse and the workflow became undispatchable — it registered by filename rather than by name. Caught in kube-workspaces/deploy before this branch merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first real release (v0.2.1) published notes with every
code spanand thefenced code block silently removed:
${{ steps.notes.outputs.body }}interpolates the text into the shell script,so bash treats the backticks as command substitution and executes them. Every
code span became empty and the fenced block vanished.
The preamble is already written to
/tmp/preamble.md, so this uses--notes-fileand drops theGITHUB_OUTPUTround-trip entirely.The generator itself was correct — the dry-run summaries rendered properly, which
is what isolated the fault to the publishing step. The v0.2.1 release bodies have
been corrected by hand; releases from v0.2.2 onward will render correctly
unattended.
Same fix applied across all five repositories.