fix: keep hardcoded visibility for backwards compatibility#922
Merged
Conversation
Recent Kosli servers accept flow create/update without `visibility`, but older instances might still reject the payload without it. Keep sending `visibility: "private"` for backwards compatibility, with a comment marking it for removal once the minimum supported server version no longer requires the field.
Contributor
|
Claude finished @mbevc1's task in 1m 52s —— View job Review of PR #922
Static AnalysisAll checks pass: Review SummaryThis PR looks good. It's a small, focused backwards-compatibility fix that restores the What's done well:
No issues found with correctness, security, or performance. The existing |
gsavage
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore payload removed in #918 to make it compatible with older Kosli instances.
Recent Kosli servers accept flow create/update without
visibility, but older instances might still reject the payload without it. Keep sendingvisibility: "private"for backwards compatibility, with a comment marking it for removal once the minimum supported server version no longer requires the field.