test: cover protx listdiff platform port restart regression#8
Open
thepastaclaw wants to merge 1 commit into
Open
test: cover protx listdiff platform port restart regression#8thepastaclaw wants to merge 1 commit into
thepastaclaw wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Adds regression coverage for the
protx listdiffrestart/snapshot edge case fixed by dashpay#7360.When an Evo masternode moves from legacy Platform port fields to ExtAddr
netInfo, a restarted node may rebuild the deterministic MN diff from serialized state. The regression test verifies that deprecatedplatformP2PPort/platformHTTPPortfields inprotx listdiffremain consistent with the valid Platform addresses instead of reporting0.What was done?
Updated
test/functional/rpc_netinfo.pyto:-deprecatedrpc=servicenode to exercise the serialized snapshot/diff pathprotx listdiffover the ProUpServTx blockaddressesand deprecated scalar Platform port fields report the expected non-zero portsHow Has This Been Tested?
Built locally on macOS arm64 with:
./autogen.sh ./configure --without-gui --disable-bench --disable-fuzz-binary make -j$(sysctl -n hw.ncpu)Validation:
rpc_netinfo.pypassed.Pre-PR review gate:
code-review dashpay/dash knst/fix-v24-extdiff test/pr7360-listdiff-regression "Add a functional regression test covering legacy-to-ExtAddr protx listdiff deprecated Platform ports after restart/snapshot"Result:
ship.Breaking Changes
None. Test-only change.
Checklist: