Skip to content

fix: disable legacy spork P2P on mainnet#3

Open
thepastaclaw wants to merge 1 commit into
knst:refactor-spork-net-processing-v2from
thepastaclaw:fix-pr7303-disable-mainnet-spork-p2p
Open

fix: disable legacy spork P2P on mainnet#3
thepastaclaw wants to merge 1 commit into
knst:refactor-spork-net-processing-v2from
thepastaclaw:fix-pr7303-disable-mainnet-spork-p2p

Conversation

@thepastaclaw

Copy link
Copy Markdown

Follow-up for dashpay#7303

Summary

Follow-up for review feedback on dashpay#7303.

This disables the legacy P2P spork flow on mainnet now that mainnet sporks
are hardcoded/hardened:

  • skip sync-time GETSPORKS requests on mainnet
  • ignore mainnet SPORK and GETSPORKS messages without serving cached state
  • treat mainnet MSG_SPORK inventory as already-have and skip requesting it
  • avoid serving MSG_SPORK over GETDATA
  • avoid relaying spork inventory on mainnet
  • preserve existing non-mainnet spork P2P behavior

Validation

  • git diff --check
  • Code review gate passed with recommendation: ship
  • Attempted src/test/test_dash --run_test=spork_tests; skipped because this
    worktree does not have a built src/test/test_dash binary

@thepastaclaw

Copy link
Copy Markdown
Author

@coderabbitai review

@thepastaclaw

thepastaclaw commented Jun 16, 2026

Copy link
Copy Markdown
Author

✅ Review complete (commit de8496c)

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Small, well-scoped change that consistently disables the legacy P2P spork flow on mainnet across request/serve/relay/sync paths while preserving behavior on other networks. No correctness, consensus, or security issues. Agent findings were cosmetic/observational and not actionable.

GitHub does not allow PastaClaw to approve their own PR, so this is posted as a COMMENT review rather than an APPROVE review.

No findings.

@thepastaclaw thepastaclaw marked this pull request as ready for review June 16, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant