fix: consistent head handling.#96
Merged
knightedcodemonkey merged 4 commits intonextfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make PR drawer “head” (and related PR drawer metadata) behave consistently across repository/context transitions by ensuring programmatic form updates trigger workspace-metadata persistence, and by ensuring a fresh local workspace has a non-empty head branch that can be persisted/restored.
Changes:
- Added helpers to set PR drawer form values while emitting
inputevents so workspace metadata persistence runs for programmatic updates. - Ensured inactive/local workspaces start with a generated
headbranch and that startup flushes an initial workspace save early. - Added Playwright coverage for bootstrapping persistence and head stability across repository changes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/modules/github/pr/drawer/controller/repository-form.js |
Emits metadata input events when setting repo/base/head/title programmatically to persist workspace metadata. |
src/modules/github/pr/drawer/controller/create-controller.js |
Forces a full form sync after hydrating an active PR context. |
src/modules/app-core/workspace-pr-session-handoff-controller.js |
Generates a fresh local head branch and persists it into the created inactive workspace record. |
src/modules/app-core/app-bindings-startup.js |
Persists PR repo select changes and flushes an initial workspace save after bootstrap completes. |
src/app.js |
Wires githubPrRepoSelect into startup bindings. |
playwright/github-pr-drawer.spec.ts |
Adds tests for early persistence, head persistence, and head stability across repo changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.