Skip to content

fix(playwright): stabilize lint diagnostics.#101

Merged
knightedcodemonkey merged 1 commit intonextfrom
bananas
Apr 26, 2026
Merged

fix(playwright): stabilize lint diagnostics.#101
knightedcodemonkey merged 1 commit intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 26, 2026 17:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Playwright lint diagnostics helpers/tests to reduce flakiness by allowing a lint re-run when diagnostics don’t appear on the first attempt.

Changes:

  • Extend waitForLintDiagnosticsIssues to optionally accept a rerunLint callback and retry once if initial lint diagnostics assertions fail.
  • Update diagnostics Playwright tests to provide rerunLint (re-triggering component/styles lint) for improved stability.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
playwright/helpers/app-test-helpers.ts Adds optional one-time retry path to wait for lint diagnostics (with an injected lint re-run).
playwright/diagnostics.spec.ts Passes rerunLint to affected tests so they can re-run lint if diagnostics are not observed initially.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 92310ee into next Apr 26, 2026
10 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 26, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants