Skip to content

[WIP] feat: support multi secret namespace watch#3368

Open
YoniRomm wants to merge 1 commit into
knative:mainfrom
YoniRomm:watch-multiple-namespaces
Open

[WIP] feat: support multi secret namespace watch#3368
YoniRomm wants to merge 1 commit into
knative:mainfrom
YoniRomm:watch-multiple-namespaces

Conversation

@YoniRomm
Copy link
Copy Markdown

@YoniRomm YoniRomm commented Jun 3, 2026

Changes

Created a factory that wraps multiple informers when there is a need to watch multiple specific namespaces, overcoming the core Go library limitation which only allows an informer to watch either cluster-wide or a single namespace.

  • 🎁 Add new feature

/kind enhancement

Fixes #3367

Release Note

Added a multi-namespace informer factory to support watching multiple specific namespaces simultaneously.

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

@YoniRomm: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

create factory that warps multiple informers when needs to watach multiple namespaces as the core go library only allows
for an informer to watch cluster wide or 1 namespace only

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jun 3, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: YoniRomm / name: Yoni Romm (dd2a997)

@knative-prow knative-prow Bot requested review from creydr and skonto June 3, 2026 07:27
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YoniRomm
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

Welcome @YoniRomm! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow Bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

Hi @YoniRomm. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YoniRomm
Copy link
Copy Markdown
Author

YoniRomm commented Jun 3, 2026

/issue 3367

@YoniRomm YoniRomm changed the title feat: support multi secret namespace watch [WIP] feat: support multi secret namespace watch Jun 3, 2026
@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2026
@YoniRomm YoniRomm force-pushed the watch-multiple-namespaces branch from e5cea4c to dd2a997 Compare June 3, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

informers for multiple namespaces

1 participant