Skip to content

Add image transformer for Knative Serving Queue Proxy sidecar#2314

Open
alanrichman wants to merge 1 commit into
knative:mainfrom
alanrichman:fix-knative-serving-queue-proxy-override
Open

Add image transformer for Knative Serving Queue Proxy sidecar#2314
alanrichman wants to merge 1 commit into
knative:mainfrom
alanrichman:fix-knative-serving-queue-proxy-override

Conversation

@alanrichman
Copy link
Copy Markdown

Fixes #2313

Proposed Changes

  • Adds image transformer for Knative Serving Queue Proxy sidecar

Release Note

Fix `KnativeServing` registry override not overriding image for Knative Serving Queue Proxy sidecar

…ig-deployment configmap

Signed-off-by: Alan Richman <alanrichman@duck.com>
@knative-prow knative-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

Welcome @alanrichman! It looks like this is your first PR to knative/operator 🎉

@knative-prow knative-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

Hi @alanrichman. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot requested a review from aliok June 3, 2026 22:46
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alanrichman
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot requested a review from houshengbo June 3, 2026 22:46
Copy link
Copy Markdown

@knative-prow knative-prow Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alanrichman: 0 warnings.

Details

In response to this:

Fixes #2313

Proposed Changes

  • Adds image transformer for Knative Serving Queue Proxy sidecar

Release Note

Fix `KnativeServing` registry override not overriding image for Knative Serving Queue Proxy sidecar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Services not using correct image for queue-proxy sidecar

1 participant