Skip to content

[WIP] [DNM] kubeconfig decouple - maximum destruction#3841

Draft
gauron99 wants to merge 1 commit into
knative:mainfrom
gauron99:push-qnslkroyspnr
Draft

[WIP] [DNM] kubeconfig decouple - maximum destruction#3841
gauron99 wants to merge 1 commit into
knative:mainfrom
gauron99:push-qnslkroyspnr

Conversation

@gauron99
Copy link
Copy Markdown
Contributor

No description provided.

@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 24, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow Bot added the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label May 24, 2026
@knative-prow knative-prow Bot requested review from dsimansk and jrangelramos May 24, 2026 15:37
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. labels May 24, 2026
@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch from 2aee563 to 94a4752 Compare May 24, 2026 15:40
@gauron99 gauron99 changed the title kubeconfig decouple - maximum destruction [WIP] [DNM] kubeconfig decouple - maximum destruction May 24, 2026
@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch from 94a4752 to 672471b Compare May 24, 2026 15:47
@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch from 672471b to f74082e Compare May 24, 2026 15:49
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 68.11398% with 235 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.91%. Comparing base (bf19b17) to head (42f747e).

Files with missing lines Patch % Lines
cmd/logs.go 8.57% 32 Missing ⚠️
pkg/k8s/persistent_volumes.go 31.11% 31 Missing ⚠️
cmd/environment.go 0.00% 23 Missing ⚠️
pkg/k8s/client.go 85.15% 16 Missing and 3 partials ⚠️
pkg/deployer/testing/integration_test_helper.go 0.00% 18 Missing ⚠️
cmd/deploy.go 76.27% 11 Missing and 3 partials ⚠️
pkg/k8s/openshift.go 50.00% 9 Missing and 1 partial ⚠️
cmd/config_volumes.go 0.00% 9 Missing ⚠️
cmd/client.go 80.48% 5 Missing and 3 partials ⚠️
cmd/config_envs.go 0.00% 8 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
+ Coverage   52.97%   53.91%   +0.94%     
==========================================
  Files         200      200              
  Lines       23526    23783     +257     
==========================================
+ Hits        12462    12822     +360     
+ Misses       9841     9735     -106     
- Partials     1223     1226       +3     
Flag Coverage Δ
e2e 33.74% <54.18%> (+12.07%) ⬆️
e2e go 29.44% <37.01%> (-0.01%) ⬇️
e2e node ?
e2e python ?
e2e quarkus 25.91% <36.85%> (+0.03%) ⬆️
e2e rust ?
e2e springboot 24.07% <36.39%> (+0.04%) ⬆️
e2e typescript 25.90% <36.85%> (+0.03%) ⬆️
e2e-config-ci 26.99% <30.01%> (+0.01%) ⬆️
integration 15.55% <24.24%> (-0.18%) ⬇️
unit macos-14 43.07% <44.57%> (+0.30%) ⬆️
unit macos-latest 43.07% <44.57%> (+0.30%) ⬆️
unit ubuntu-24.04-arm 43.38% <44.91%> (+0.28%) ⬆️
unit ubuntu-latest 43.92% <44.57%> (+0.29%) ⬆️
unit windows-latest 43.14% <44.57%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch from f74082e to 46ff7e2 Compare May 24, 2026 16:38
@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label May 29, 2026
@lkingland lkingland added the status/new Accepted to Traige label Jun 2, 2026
@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch from 46ff7e2 to 07b6cf0 Compare June 3, 2026 16:39
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Jun 3, 2026
@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch 2 times, most recently from fcc8739 to 5960589 Compare June 4, 2026 05:25
@gauron99 gauron99 force-pushed the push-qnslkroyspnr branch from 5960589 to 42f747e Compare June 4, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. size/XXL 🤖 PR changes 1000+ lines, ignoring generated files. status/new Accepted to Traige

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants