ci: add free-disk-space cleanup to test-e2e-podman job#3557
Conversation
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
size/S
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce disk-pressure failures in CI by standardizing the use of a free-disk-space cleanup step in Podman-related workflows, aligning test-e2e-podman with other existing E2E jobs.
Changes:
- Add
endersonmenezes/free-disk-space@v3cleanup step to thetest-e2e-podmanjob in the main CI workflow. - Replace the bespoke “Remove Unnecessary Software” shell cleanup in the scheduled Podman Next workflow with the same free-disk-space action.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/test-podman-next.yaml | Replaces manual disk cleanup commands with the shared free-disk-space action in the scheduled Podman Next workflow. |
| .github/workflows/functions.yaml | Adds the free-disk-space action step to test-e2e-podman to match sibling E2E jobs and reduce disk pressure before installing Podman. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
All sibling E2E jobs free disk before running; test-e2e-podman was the only exception. It installs podman (large), so disk pressure is more likely here than anywhere else.
Ankitsinghsisodya
force-pushed
the
ci/add-free-disk-space-to-e2e-podman-clean
branch
from
0581755 to
4ab8502
Compare
knative-prow
bot
added
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3557 +/- ##
==========================================
+ Coverage 55.52% 56.25% +0.72%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11363 11512 +149
+ Misses 7902 7754 -148
+ Partials 1200 1199 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ankitsinghsisodya, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Summary
endersonmenezes/free-disk-space@v3step to thetest-e2e-podmanjob, immediately afterknative/actions/setup-go@maintest-e2e-podmanconsistent with all other sibling E2E jobs (test-integration,test-e2e,test-e2e-runtimes,test-e2e-config-ci) which already run this cleanup stepFixes #3553