Skip to content

Remove venv creation for python package install stage - #3366

Draft
T-Dynamos wants to merge 2 commits into
kivy:developfrom
T-Dynamos:platform-tag
Draft

Remove venv creation for python package install stage#3366
T-Dynamos wants to merge 2 commits into
kivy:developfrom
T-Dynamos:platform-tag

Conversation

@T-Dynamos

Copy link
Copy Markdown
Member
  • Virtual environment creation is not required now as we are using our own custom pip now.
  • This PR strictly prevents to install wrong arch modules like it was allowed previously causing issues like: Tiktoken is for EM_X86_64 | ImportError: dlopen failed () #3050
  • It might break for some users which are dependent on this behavior.
  • It also changes how setup.py runs and uses a more simplified approach.
  • Now full compatible with native android packages on pypi like charset-normalizer are installable without recipes (it directly picks up android wheels from pypi)

@RobertFlatt

Copy link
Copy Markdown
Contributor

Strangely using this pr and specifying one of chardet or charset-normalizer in requirements, appears to result in both in the build (yes I appclean'd in between).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants