Skip to content

refactor(displays): move overlay placement geometry onto the alignment - #102

Merged
esphynox merged 2 commits into
mainfrom
refactor/keyboard-visualizer-placement
Aug 14, 2026
Merged

refactor(displays): move overlay placement geometry onto the alignment#102
esphynox merged 2 commits into
mainfrom
refactor/keyboard-visualizer-placement

Conversation

@esphynox

@esphynox esphynox commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes issue (#103)

  • Move keyboard overlay placement geometry onto the alignment model so preview positioning and live placement use the same source of truth.
  • Keep custom placement anchored to the selected preview point instead of recalculating from separate window geometry.
  • Add focused placement and normalized-point tests to cover the new alignment behavior.

Tests

  • tuist generate
  • xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'
  • Other:

Run project commands from Apps/Keyty.

UI Changes

Attach screenshots or screen recordings for visible UI changes. Write N/A if there are none.

Before After
keyty-custom-alignment-before.mov
keyty-custom-alignment-after.mov

Documentation

  • Updated relevant docs
  • No docs needed

Release Notes

Improve keyboard overlay custom placement so the overlay stays aligned to the selected anchor in display previews and live placement.

@esphynox esphynox self-assigned this Aug 14, 2026
@esphynox esphynox added the bug Something isn't working label Aug 14, 2026
@esphynox
esphynox marked this pull request as ready for review August 14, 2026 15:22
@esphynox
esphynox merged commit b57c248 into main Aug 14, 2026
1 check passed
@esphynox
esphynox deleted the refactor/keyboard-visualizer-placement branch August 14, 2026 15:28
esphynox added a commit that referenced this pull request Aug 15, 2026
…acement

refactor(displays): move overlay placement geometry onto the alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant