Fix signup crash: click event laundered into username route param#29281
Merged
chrisnojima merged 1 commit intoJun 3, 2026
Merged
Conversation
Base automatically changed from
nojima/HOTPOT-faster-devices
to
nojima/HOTPOT-next-670-clean-2
June 3, 2026 20:30
ReloginContainer wired useRequestAutoInvite()'s raw fn directly as onSignup, so the click event became the `username` arg, flowed through navigateAppend as a route param, and crashed signup's username.trim(). Make the hook param required (username: string) so a bare assignment to a () => void handler prop is now a compile error, preventing the event from being laundered into a string-typed slot. No-username callers pass '' explicitly.
chrisnojima
force-pushed
the
nojima/HOTPOT-fix-signedout
branch
from
fca7656 to
0fb954b
Compare
chrisnojima
merged commit 7010fd6
into
nojima/HOTPOT-next-670-clean-2
1 check was pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReloginContainer wired useRequestAutoInvite()'s raw fn directly as onSignup, so the click event became the
usernamearg, flowed through navigateAppend as a route param, and crashed signup's username.trim().Make the hook param required (username: string) so a bare assignment to a () => void handler prop is now a compile error, preventing the event from being laundered into a string-typed slot. No-username callers pass '' explicitly.