Skip to content

Deprecate .json fetching from reddit#29279

Merged
michalz-zoom merged 9 commits into
masterfrom
dev/michal/reddit-rss-pvl
Jun 4, 2026
Merged

Deprecate .json fetching from reddit#29279
michalz-zoom merged 9 commits into
masterfrom
dev/michal/reddit-rss-pvl

Conversation

@michalz-zoom
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread pvl-tools/tab/1.cson Outdated
# { assert_regex_match: {
# , pattern: "^Listing$"
# , from: "kind"
# , error: ["CONTENT_FAILURE", "Wanted a post of type 'Listing', but got '%{kind}'"] } },
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove, doing some checks if we can get tricked if we are served non-post .rss

Comment thread go/tools/pvlcheck/main.go Outdated
service = flag.String("service", "", "service to run, e.g. twitter, github, reddit, facebook, hackernews, generic_web_site (required)")
version = flag.String("version", "1", "pvl version chunk to use from the kit's tab")
apiURL = flag.String("api-url", "", "value of the hint_url register (the proof's API url)")
sig = flag.String("sig", "", "armored signature for the proof; defaults to a public test sig")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no default?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, fixed

@michalz-zoom michalz-zoom force-pushed the dev/michal/reddit-rss-pvl branch 2 times, most recently from 24bf164 to 917d530 Compare June 3, 2026 19:46
@michalz-zoom michalz-zoom force-pushed the dev/michal/reddit-rss-pvl branch from 917d530 to 4dd234b Compare June 3, 2026 20:42
@michalz-zoom michalz-zoom merged commit 764edf1 into master Jun 4, 2026
1 check passed
@michalz-zoom michalz-zoom deleted the dev/michal/reddit-rss-pvl branch June 4, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants