infamy: fix NameError in Topology.get_password (qstrip -> _qstrip) - #1588
Merged
Conversation
17 tasks
The password attribute was read with a call to qstrip(), but the helper is named _qstrip(). Any physical topology that sets a per-node password (or an unquoted value needing stripping) crashed with NameError during attach. Co-authored-by: Jarvis (Hermes Agent) <jarvis@woxblom.com>
pjator
force-pushed
the
fix-infamy-qstrip
branch
from
August 16, 2026 07:41
6e68522 to
ced1e0e
Compare
wkz
approved these changes
Aug 16, 2026
wkz
left a comment
wkz
left a comment
Contributor
There was a problem hiding this comment.
Unsurprisingly, all nodes in our test systems run with the default admin/admin credentials 😆
Good find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a
NameErrorin the Infamy test harness.Topology.get_password()called
qstrip()but the helper is defined as_qstrip()— so anyphysical topology that sets a per-node
passwordattribute (or anyvalue needing quote-stripping) crashed during
env.attach().Found while running the hardware regression suite against a physical
device. Worked around locally, this is the proper upstream fix.
Checklist
Tick relevant boxes, this PR is-a or has-a:
Disclaimer: Author: Peter Woxblom. Drafting and implementation assisted
by Jarvis, an AI agent (Hermes on DeepSeek V4 Flash backend). Reviewed
and tested on hardware by the author.