jwt: Add unified_secret handling#34
Merged
nuclearcat merged 4 commits intokernelci:mainfrom Apr 15, 2026
Merged
Conversation
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
There was a problem hiding this comment.
Pull request overview
Adds support for verifying JWTs using an additional configuration key (unified_secret) as a fallback to jwt_secret, centralizing the verification logic in a helper.
Changes:
- Introduces
verify_with_key_strhelper to verify a token with a provided secret and validate required claims. - Updates
verify_jwt_tokento tryjwt_secretfirst, then fall back tounified_secretif present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+48
to
+49
|
|
||
| Err(jwt::Error::InvalidSignature) |
There was a problem hiding this comment.
When jwt_secret verification fails and unified_secret is not configured, the function returns a generic jwt::Error::InvalidSignature here, discarding the original verification error from the first attempt. Consider carrying the first error through (e.g., store it and return it when no fallback key exists) so failures are diagnosed accurately.
…on too Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
jwt seems abandoned 5 years ago Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.