Skip to content

ci: add lint and build checks on PRs#93

Open
ulziibay-kernel wants to merge 4 commits intomainfrom
add-ci-workflow
Open

ci: add lint and build checks on PRs#93
ulziibay-kernel wants to merge 4 commits intomainfrom
add-ci-workflow

Conversation

@ulziibay-kernel
Copy link
Copy Markdown
Contributor

@ulziibay-kernel ulziibay-kernel commented Apr 8, 2026

Summary

  • Adds a CI workflow that runs bun run lint and bun run build on every PR to main
  • Required for SOC 2 CHG-1 (change management) — enforces automated testing before merge

Test plan

  • Verify CI runs on this PR
  • Once merged, add ci as a required status check on branch protection

Made with Cursor


Note

Low Risk
Low risk: adds a new GitHub Actions workflow only, running dependency install and tsc type-checking on PRs/merge queue without changing runtime code paths.

Overview
Adds a new GitHub Actions CI workflow that triggers on pull_request to main and merge_group events.

The job sets up Bun, installs dependencies with --frozen-lockfile, and runs a TypeScript type check via bunx tsc --noEmit to gate changes on compile-time correctness.

Reviewed by Cursor Bugbot for commit 290a457. Bugbot is set up for automated code reviews on this repo. Configure here.

Required for SOC 2 change management controls — ensures all code
changes to main are tested before merge.

Made-with: Cursor
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mcp Ready Ready Preview, Comment Apr 8, 2026 3:41pm

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit de12f85. Configure here.

- run: bun install --frozen-lockfile

- name: Format check
run: bun run format:check
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI runs format check instead of lint as described

Medium Severity

The PR description states this workflow "runs bun run lint and bun run build" for SOC 2 CHG-1 compliance, but the workflow actually runs bun run format:check instead of bun run lint. These are fundamentally different checks — lint runs ESLint to catch code bugs and anti-patterns, while format:check only runs Prettier to verify whitespace and formatting. The SOC 2 compliance claim of "enforces automated testing before merge" is weakened since no actual linting occurs. Per AGENTS.md, next lint is broken on Next.js 16, so either a working ESLint configuration needs to be set up, or the compliance documentation needs to accurately reflect that only formatting is checked.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit de12f85. Configure here.

Copy link
Copy Markdown
Collaborator

@masnwilliams masnwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm — small CI workflow, does what it says. type check only for now (no lint/build), but fine as a starting point for SOC 2 CHG-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants