Optimize restore network setup#264
Merged
Merged
Conversation
This was referenced Jun 1, 2026
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR repository is not specified; cannot confirm it belongs to kernel, infra, hypeman, or hypeship repos. To monitor this PR anyway, reply with |
sjmiller609
commented
Jun 1, 2026
rgarcia
approved these changes
Jun 1, 2026
0e63fd2 to
4d71b40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ip link ... bridge_slave isolated onwith netlink bridge port isolation.Tests
git diff --checkgo test ./lib/network -count=1go test -tags containers_image_openpgp ./lib/instances -run TestCreateInstanceClearsRetentionStateBeforeMetadataSave -count=1Note
Medium Risk
Touches live VM network allocation and TAP/bridge isolation paths; behavior should be equivalent but errors or kernel/netlink differences could affect restores and isolated networks.
Overview
CreateAllocation now loads the allocation list once while holding the manager lock and reuses that snapshot for instance-name checks, IP pick, and MAC generation via new helpers (
nameExistsInAllocations,allocateNextIPFromAllocations,allocateUniqueMACFromAllocations), cutting repeatedListAllocationswork during allocation.On Linux TAP setup, the code reuses the netlink link object returned from
LinkAddinstead of a secondLinkByNamelookup, and sets bridge port isolation withnetlink.LinkSetIsolatedinstead of shelling out toip link … bridge_slave isolated on.Reviewed by Cursor Bugbot for commit 4d71b40. Bugbot is set up for automated code reviews on this repo. Configure here.