Skip to content

Add CloudFormation benchmark options#237

Merged
rgarcia merged 2 commits into
mainfrom
hypeship/cfn-benchmark-options
Jul 17, 2026
Merged

Add CloudFormation benchmark options#237
rgarcia merged 2 commits into
mainfrom
hypeship/cfn-benchmark-options

Conversation

@rgarcia

@rgarcia rgarcia commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add optional HTTP/HTTPS ingress parameters for the quickstart security group
  • add gp3 IOPS and throughput parameters for the Hypeman data volume
  • move root/data block-device mappings into the launch template helper so gp3 throughput and nested virtualization are configured together
  • extend CloudFormation template contract tests for the new parameters and launch-template payload

Tests

  • go test ./... (deploy/aws/cloudformation)
  • git diff --check origin/main...HEAD

Note

Medium Risk
Enabling ingress exposes web ports on the instance; defaults stay closed, but mis-set AllowedIngressCidr could widen attack surface when toggles are on.

Overview
Adds optional public ingress to the Hypeman EC2 quickstart stack via new CloudFormation parameters EnableHttpIngress, EnableHttpsIngress, and AllowedIngressCidr (all surfaced under the Network parameter group, defaulting to off with 127.0.0.1/32).

When enabled, HypemanSecurityGroup gains conditional !If rules for TCP 80 and 443 scoped to AllowedIngressCidr, alongside the existing API and SSH rules. The launch-template helper comment is updated to note gp3 throughput as another reason that helper exists.

Contract tests now assert the new parameter defaults, ingress CIDR guidance text, four security-group ingress entries, and a shared assertConditionalIngress helper for the HTTP/HTTPS !If blocks.

Reviewed by Cursor Bugbot for commit b928d6f. Bugbot is set up for automated code reviews on this repo. Configure here.

@rgarcia
rgarcia marked this pull request as ready for review May 18, 2026 13:26
@rgarcia
rgarcia requested a review from sjmiller609 May 18, 2026 13:27
@firetiger-agent

Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: Changes are limited to CloudFormation templates and AWS deployment configuration, not to API endpoints or Temporal workflows.

To monitor this PR anyway, reply with @firetiger monitor this.

@rgarcia
rgarcia merged commit d60d4d1 into main Jul 17, 2026
17 of 18 checks passed
@rgarcia
rgarcia deleted the hypeship/cfn-benchmark-options branch July 17, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants