Add CloudFormation benchmark options#237
Merged
Merged
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: Changes are limited to CloudFormation templates and AWS deployment configuration, not to API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
sjmiller609
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note
Medium Risk
Enabling ingress exposes web ports on the instance; defaults stay closed, but mis-set
AllowedIngressCidrcould widen attack surface when toggles are on.Overview
Adds optional public ingress to the Hypeman EC2 quickstart stack via new CloudFormation parameters
EnableHttpIngress,EnableHttpsIngress, andAllowedIngressCidr(all surfaced under the Network parameter group, defaulting to off with127.0.0.1/32).When enabled,
HypemanSecurityGroupgains conditional!Ifrules for TCP 80 and 443 scoped toAllowedIngressCidr, alongside the existing API and SSH rules. The launch-template helper comment is updated to note gp3 throughput as another reason that helper exists.Contract tests now assert the new parameter defaults, ingress CIDR guidance text, four security-group ingress entries, and a shared
assertConditionalIngresshelper for the HTTP/HTTPS!Ifblocks.Reviewed by Cursor Bugbot for commit b928d6f. Bugbot is set up for automated code reviews on this repo. Configure here.