Skip to content

ci: add Semgrep SAST scanning on pull requests #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ulziibay-kernel merged 1 commit into from
Apr 10, 2026
Merged

ci: add Semgrep SAST scanning on pull requests #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/semgrep.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Semgrep

on:
pull_request:
branches: [main]

permissions:
contents: read
pull-requests: write

jobs:
scan:
uses: kernel/security-workflows/.github/workflows/semgrep.yml@main
with:
extra-configs: '--config p/golang --config p/trailofbits'
codebase-description: 'Hypervisor runtime managing VMs for customer browser sessions'
secrets: inherit
5 changes: 5 additions & 0 deletions .semgrepignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
node_modules/
vendor/
dist/
*_test.go
go.sum
Copy link
Copy Markdown

@cursor cursor bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated Go files not excluded from scanning

Medium Severity

The .semgrepignore file doesn't actually exclude any of the repository's generated Go files, despite the PR description stating it covers generated code. Files like cmd/api/wire_gen.go (Wire), lib/guest/guest.pb.go and lib/guest/guest_grpc.pb.go (protobuf), lib/oapi/oapi.go, and lib/vmm/vmm.go (oapi-codegen) are all generated and marked with "DO NOT EDIT" but will still be scanned, likely producing false positives that create CI noise or block PRs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9c774a2. Configure here.

Loading