Skip to content

Add error-path diagnostics for cloud-hypervisor startup#195

Open
sjmiller609 wants to merge 1 commit intomainfrom
codex/add-start-vm-failure-diagnostics
Open

Add error-path diagnostics for cloud-hypervisor startup#195
sjmiller609 wants to merge 1 commit intomainfrom
codex/add-start-vm-failure-diagnostics

Conversation

@sjmiller609
Copy link
Copy Markdown
Collaborator

@sjmiller609 sjmiller609 commented Apr 10, 2026

Summary

  • add failure-only diagnostics around cloud-hypervisor create/boot requests
  • capture context cancellation state, deadline info, socket/process health, and a short vmm.log tail on failure
  • keep the normal success path unchanged

Testing

  • go test ./lib/hypervisor/cloudhypervisor

Notes

  • broader package tests in this worktree are currently blocked by existing missing embedded binaries for vz-shim/guest-agent

Note

Low Risk
Low risk: adds failure-only logging/diagnostics around Cloud Hypervisor StartVM HTTP calls without changing the success path or VM control flow.

Overview
Improves Cloud Hypervisor startup troubleshooting by emitting failure-only diagnostics when CreateVM or BootVM requests error or return non-204.

The new diagnostics log context cancellation/deadline details, socket existence/dialability, CH process liveness, and a truncated tail of logs/vmm.log, with response bodies/errors truncated to limit log volume.

Reviewed by Cursor Bugbot for commit 126b210. Bugbot is set up for automated code reviews on this repo. Configure here.

@sjmiller609 sjmiller609 marked this pull request as ready for review April 10, 2026 15:42
@firetiger-agent
Copy link
Copy Markdown

Firetiger deploy monitoring skipped

This PR didn't match the auto-monitor filter configured on your GitHub connection:

Any PR that changes the kernel API. Monitor changes to API endpoints (packages/api/cmd/api/) and Temporal workflows (packages/api/lib/temporal) in the kernel repo

Reason: PR modifies cloud-hypervisor diagnostics in the hypervisor package, not kernel API endpoints or Temporal workflows as specified in the filter.

To monitor this PR anyway, reply with @firetiger monitor this.

@sjmiller609 sjmiller609 requested a review from hiroTamada April 10, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant