BUG: Resample multi-series indicator inputs consistently - #1390
Open
Jaco-Ren wants to merge 1 commit into
Open
Conversation
Jaco-Ren
marked this pull request as ready for review
August 12, 2026 14:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strategy.dataarray pathMotivation and Context
Fixes #1243.
resample_apply()currently resamples only its primaryseries. Additional inputs passed through*argsremain at the source frequency, so a call such as:passes daily High values together with minute-level Low and Close values. Multi-series indicators therefore receive incompatible lengths and indexes and may fail before producing a result.
The change recognizes pandas Series/DataFrames and Strategy data arrays only when they share the primary series' original index. Those inputs are resampled with their field-specific defaults (
High=max,Low=min,Close=last, etc.); scalar parameters and unrelated arguments remain unchanged. The existinglabel='right'behavior is preserved so a higher-timeframe value becomes available only after that period is complete, avoiding look-ahead bias.Testing
_Arrayvaluespython -m unittest backtesting.test._test.TestLib.test_resample_apply backtesting.test._test.TestLib.test_resample_apply_multiple_seriespython -m backtesting.test- 82 passed, 1 skippedgit diff --checkTypes of changes