feat(vibe): Add Naver VIBE provider by Lioncat6 · Pull Request #209 · kellnerd/harmony

Lioncat6 · 2026-04-05T07:20:05Z

Got bored and decided to implement VIBE as well...

Might want to take a look at here in particular: https://github.com/kellnerd/harmony/compare/main...Lioncat6:harmony:vibe?expand=1#diff-994ea9806a6ec65de9b9322a6997658f145c4b9a0fc8e88570a249f0a6f34970R145-R258

Closes #208

Lioncat6 · 2026-04-05T07:31:35Z

Some albums with a lot of featuring artists for testing:
https://vibe.naver.com/album/10304443
https://vibe.naver.com/album/638616
https://vibe.naver.com/album/3034414

kellnerd

Wow, that was fast...

Originally I wanted to continue working on my Discogs provider today, then I decided to give you some quick initial feedback first, but in the end I found a few more things 😅

kellnerd · 2026-04-05T10:02:56Z

+	override readonly launchDate: PartialDate = {
+		year: 2007,
+		month: 8,
+	};


Should be June 11 2018.
Please be very careful when copy-pasting other provider implementations, it is very easy to introduce mistakes and unused code which makes review/maintenance much harder.
There is a reason I have an empty provider template, although I could probably refine it a bit now that there are more provider implementations which often have the same de-facto standard methods.

This is actually a bit of a tricky one, since, as the article says, Naver Vibe merged with their second product, Naver Music, in 2020. Naver Music existed much longer than Naver Vibe, specifically since 2002, if this article is to be believed. What's interesting is that the IDs from Naver Music and Naver Vibe are identical, going way back and allowing MusicBrainz to migrate the old links to the Vibe format some time ago: https://tickets.metabrainz.org/browse/MBS-13922

So I'd argue this new provider should have the earlier launch date, even if it's technically not 100% correct for Vibe.

cc @kellnerd since this is resolved and to make sure you see it.

I'll un-resolve it for now :)

Ok, if there are releases on Vibe which could be as old as from 2002, then I agree with using that as the launch date.

P.S. I get notified about all comments in this repo whether you ping me or not 😀
But un-resolving the thread was a good idea, otherwise it is impossible to see this without following a link from an email notification.

The website appears to have worked a lot differently back then, but for our purposes, I think using 2002 as a launch date is adequate. The (perhaps slightly later?) album URL format still redirects to Vibe: http://music.naver.com/album/index.nhn?albumId=2

Right, sorry about that. I'll keep it in mind for the future. And yes, thanks for un-resolving the thread!

kellnerd · 2026-04-05T10:13:32Z

+	}
+
+	override getLinkTypesForEntity(): LinkType[] {
+		return ['paid streaming', 'paid download'];


Is this correct, do they have downloads?

Yup, though I need to add validation for which tracks do, since all tracks marked as 'overseas' don't

Is there a way to specify link types for recordings?

Every naver track can be downloaded, but not every album can.

Resolved but keeping this open

kellnerd · 2026-04-05T10:48:03Z

+		})
+	}
+
+	private async getTrackArtists(rawTrack: NaverTrack): Promise<ArtistCreditName[]> {


It's hard to follow what is happening here... I would like to see some test cases for this function to see what it is supposed to do and if it can be written in a more obvious way. For example, I also have the feeling that we don't have to distinguish between participants and artists in the end and can have one function which converts artists with optional join phrases but I don't feel confident to try without having test coverage.

Where all other providers (minus Apple and tidal apparently) would provide all participating main track credits, Naver does not and instead moves featuring artists exclusively to the /credits endpoint for tracks

See: https://harmony.pulsewidth.org.uk/release?url=&gtin=0692788693392&region=&musicbrainz=&deezer=&itunes=&spotify=&tidal= for the album on other services

The album tracks fetch here: album/34923420/tracks.json omits the featuring artists, so they have to be fetched with track/96143271/credits.json (track/96143271.json returns the same thing as the album tracks fetch). But /credits also returns all artist roles, including non-participating roles which can be seen here

I should probably make a helper function to generate the join phrases for the artists, since vibe does distinguish between featuring artists and main artists, unlike most other providers

What the logic is currently doing:

Check if the track title has an indicator of featuring artists to attempt to save on extra calls; Can be removed if unreliable if (!trackFeatVariations.some((fv) => rawTrack.trackTitle.toLocaleLowerCase().includes(fv))) {

Fetch track credits const trackCredits = await this.getRawTrackCredits(rawTrack.trackId);

Filter out featuring artists const featuringArtists = roles.filter((role) => role.roleName === '피쳐링').flatMap((role) => role.participantList);

Store the ids of the featuring artists const featuringIds = featuringArtists.map((artist) => artist.id);

Combine and de duplicate all artists typescript const uniqueArtists = Array.from(new Map(allArtists.map((artist) => [artist.id, artist])).values());

Use a forEach loop to check the positions of the nearby artists to generate the joinPhrases & map to convertRawParticipant

Return credits

I want to make a helper function that replaces the job of step 6

…rases

kellnerd · 2026-04-13T19:40:21Z

Quick update (since the weekend has already passed and I found no time for your PRs): Code-wise this is looking good, but I still have to actually test the provider with a few releases myself.

Maxr1998 · 2026-04-28T20:11:36Z

Tested this the other day to add a new release, worked really well! Is there any other tests you'd like me to do?

Lioncat6 · 2026-04-30T23:33:55Z

@Maxr1998 Thanks for looking at it! I still need to make that helper function, and I need to double check to make sure that all tracks on VIBE with featuring artists have one of these strings in the track title.

kellnerd · 2026-05-01T19:40:55Z

There is no official checklist for new providers yet, but it would probably be good to have one.
Other than the obvious stuff (does it crash? any errors in the displayed/seeded data?) and the automatic provider test cases, I usually check that the lookups are reasonably fast, permalinks are working and how a provider behaves for different kinds of releases (many tracks, multiple artists, API properties which look like they could have unexpected values).
I also have an eye on the size of cached data and if there may be better ways to get the same information or if there are any requests which we can omit.

feat(vibe): Add Naver VIBE provider

54520f1

kellnerd added feature New feature or request provider Metadata provider labels Apr 5, 2026

kellnerd requested changes Apr 5, 2026

View reviewed changes

Lioncat6 added 2 commits April 5, 2026 15:13

chore(vibe): Resolve some basic issues

ba1fd30

chore(vibe): Formatting

4f183ee

Lioncat6 force-pushed the vibe branch from 4f81f79 to 4f183ee Compare April 5, 2026 21:19

Lioncat6 and others added 6 commits April 5, 2026 16:19

chore(vibe): Unwrap raw API responses

ee1e023

chore(vibe): Use parseDuration for track length

f4125c9

test(vibe): Add more comprehensive tests for artist credits / join ph…

20cff5a

…rases

test(vibe): Formatting

d70ead8

chore(vibe): Determine release link types

03bf03d

test(vibe): Test for link types

cbd422d

Conversation

Lioncat6 commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lioncat6 commented Apr 5, 2026

Uh oh!

kellnerd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lioncat6 Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kellnerd commented Apr 13, 2026

Uh oh!

Maxr1998 commented Apr 28, 2026

Uh oh!

Lioncat6 commented Apr 30, 2026

Uh oh!

kellnerd commented May 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lioncat6 commented Apr 5, 2026 •

edited

Loading

Lioncat6 Apr 30, 2026 •

edited

Loading