fix: space announcement retransmissions wider than the rate-limit window#477
Open
keepsimple1 wants to merge 2 commits into
Open
fix: space announcement retransmissions wider than the rate-limit window#477keepsimple1 wants to merge 2 commits into
keepsimple1 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The two unsolicited announcements required by RFC 6762 §8.3 were scheduled exactly 1000ms apart, the same as the §6 multicast rate-limit window. Because the schedule base time is captured before the records are stamped as multicast, the second announcement lands slightly under 1000ms after the stamp and is throttled away by the rate limit — leaving only one unsolicited response and violating §8.3's "at least two".
The fix
Schedule the second announcement strictly wider than the rate-limit window (ANNOUNCE_SECOND_DELAY_MILLIS = window + 100ms) plus a small random jitter, at both scheduling sites.