Skip to content

feat: handle CRD lifecycle in helm backend chart #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alokkumardalei-wq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: handle CRD lifecycle in helm backend chart #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ube-bind.io_apiservicebindingbundles.yaml → ...ube-bind.io_apiservicebindingbundles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -147,3 +148,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...crds/kube-bind.io_apiservicebindings.yaml → ...crds/kube-bind.io_apiservicebindings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -461,3 +462,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...ube-bind.io_apiserviceexportrequests.yaml → ...ube-bind.io_apiserviceexportrequests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -514,3 +515,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions .../crds/kube-bind.io_apiserviceexports.yaml → .../crds/kube-bind.io_apiserviceexports.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -750,3 +751,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...be-bind.io_apiserviceexporttemplates.yaml → ...be-bind.io_apiserviceexporttemplates.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -335,3 +336,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...ds/kube-bind.io_apiservicenamespaces.yaml → ...ds/kube-bind.io_apiservicenamespaces.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -122,3 +123,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...be-bind.io_bindableresourcesrequests.yaml → ...be-bind.io_bindableresourcesrequests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -222,3 +223,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...ckend/crds/kube-bind.io_boundschemas.yaml → ...lates/crds/kube-bind.io_boundschemas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -466,3 +467,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...nd/crds/kube-bind.io_clusterbindings.yaml → ...es/crds/kube-bind.io_clusterbindings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -343,3 +344,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...s/backend/crds/kube-bind.io_clusters.yaml → ...templates/crds/kube-bind.io_clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -104,3 +105,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
2 changes: 2 additions & 0 deletions ...ackend/crds/kube-bind.io_collections.yaml → ...plates/crds/kube-bind.io_collections.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.crds.install }}
---
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
Expand Down Expand Up @@ -131,3 +132,4 @@ spec:
storage: true
subresources:
status: {}
{{- end }}
5 changes: 5 additions & 0 deletions deploy/charts/backend/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,3 +262,8 @@ tolerations: []

# -- Affinity rules for pod scheduling
affinity: {}

# CRD configuration
crds:
# -- Install CustomResourceDefinitions
install: true
1 change: 1 addition & 0 deletions hack/tools.checksums
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ gotestsum|GOARCH=amd64;GOOS=linux|ee25248e6f5073cad0b7a712c97ed473adb7420f7eefad
gotestsum|GOARCH=arm64;GOOS=linux|7a5e7f8cb5e2126be563b7c7182cc4522fbc65408a99df82d156d30e997b8705
helm-docs|ARCH=arm64;OS=Darwin|911f2763de0201b4870b3468247ef794d9401aa8d4aa285089bbee040d4ae9c4
helm|GOARCH=amd64;GOOS=linux|c153fd9c1173f39aefe8e9aa9f00fd3daf6b40c8ea01e94a0d2f2c1787fc60e0
helm|GOARCH=arm64;GOOS=darwin|1de70a09e537814ce04aeae15204dcfd7a2fe1ac842e7e9ac0ebcee27b33278f
kcp|GOARCH=amd64;GOOS=linux|367525b4334e30f598054a62c8f10f04c21afa480c1700d0a9dbb8c905c931a5
kcp|GOARCH=arm64;GOOS=darwin|463dd70f665baac198f2c6b979bd9dc5e4349636711509dd83fd96b05d1d0bb5
kcp|GOARCH=arm64;GOOS=linux|44e5ac1c58642b7cffa88796adf9478a9b4110e61876e83237e419fb244216c7
Expand Down
12 changes: 11 additions & 1 deletion hack/update-codegen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,17 @@ YAML_PATCH="$(UGET_PRINT_PATH=absolute make --no-print-directory install-yaml-pa
rbac:roleName=manager-role \
webhook \
paths="./..." \
output:crd:artifacts:config=../../deploy/charts/backend/crds
output:crd:artifacts:config=../../deploy/charts/backend/templates/crds

# Wrap generated CRDs in helm conditional
for CRD in ../../deploy/charts/backend/templates/crds/*.yaml; do
if [ -f "$CRD" ]; then
echo '{{- if .Values.crds.install }}' > "${CRD}.tmp"
cat "${CRD}" >> "${CRD}.tmp"
echo '{{- end }}' >> "${CRD}.tmp"
mv "${CRD}.tmp" "${CRD}"
fi
done

# Generate RBAC manifests for Helm chart from backend controllers
"$CONTROLLER_GEN" \
Expand Down
Loading