fix: migrate from deprecated OpenSSL AES API to EVP API#523
Open
TomasULR wants to merge 1 commit intokavishdevar:mainfrom
Open
fix: migrate from deprecated OpenSSL AES API to EVP API#523TomasULR wants to merge 1 commit intokavishdevar:mainfrom
TomasULR wants to merge 1 commit intokavishdevar:mainfrom
Conversation
Replace deprecated AES_set_encrypt_key, AES_encrypt, AES_set_decrypt_key, and AES_cbc_encrypt with the modern EVP_* API (EVP_aes_128_ecb for single-block encryption, EVP_aes_128_cbc for CBC decryption). These functions have been deprecated since OpenSSL 3.0 and produce compiler warnings on newer systems. Fixes kavishdevar#459
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AES_set_encrypt_key,AES_encrypt,AES_set_decrypt_key, andAES_cbc_encryptwith the modern OpenSSL 3.0 EVP APIChanges
linux/ble/bleutils.cpp:e()function: replaced withEVP_aes_128_ecb()(matches the original single-block AES-ECB behavior)decryptLastBytes()function: replaced withEVP_aes_128_cbc()with zero IV (matches the original AES-CBC behavior)EVP_CIPHER_CTX_set_padding(ctx, 0)to match the old API behavior#include <openssl/aes.h>to#include <openssl/evp.h>Fixes #459