Ensure Docker container runs as non root user#84
Open
marcofranssen wants to merge 2 commits into
Open
Conversation
6e32312 to
328a993
Compare
Collaborator
|
The non-root goal is good, but this breaks Since The It also assumes mounted data volumes are writable by UID 14000, which breaks existing deployments. The privilege drop needs to happen after the build, with a real user + home + |
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
ba7dd04 to
1d1075d
Compare
Author
|
Rebased to resolve conflict. Also addressed feedback. I have split the build from runtime stage to reduce the deps and attach surface. Indeed deployments would need to filemount directories using gid 14000 with this change to maintain file access etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to kagent-dev/kagent#1874