chore(deps): bump rescript-bindgen to ^1.4.0-beta.2 + regenerate for blend-design-system@0.0.38-beta.1 - #145
Merged
Merged
Conversation
…ate for blend-design-system@0.0.38-beta.1 rescript-bindgen 1.4.0-beta.2 fixes two regressions that blocked a clean regen against blend 0.0.38-beta.1's new ComponentTokenOverrides token-override type: - finalizePublicIds no longer hard-crashes on a public-identity collision (SEARCH_INPUT vs MODAL rangeDay configs colliding on one projection); it now degrades to a shape-disambiguated id and warns instead of aborting the run. - Anonymous @unboxed union names are now capped at 64 chars (readable prefix + shape hash) instead of enumerating every member — the longest generated identifier drops from 2,453+ chars to 114. 235 components / 226 usable / 9 need review / 0 broken (unchanged). Verified the regenerated bindings compile clean (rescript build, 320 modules, 0 errors) and are deterministic across repeated generations. Supersedes #144. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@juspay/rescript-bindgento^1.4.0-beta.2and@juspay/blend-design-systemto0.0.38-beta.1, regenerating bindings with both fixes applied. Supersedes #144, which regenerated against the same blend version but withrescript-bindgen@1.4.0-beta.1— before these fixes existed.Why not just #144
1.4.0-beta.1doesn't crash on this blend version, but its output has a real quality problem: blend0.0.38-beta.1introducesComponentTokenOverrides(aDeepPartial<ComponentTokenType>wrapper forThemeProvider's token-override prop), which exposes a large CSS-property union (csstypeProperty.*, every CSS global keyword + every named color) through a second generic path. On1.4.0-beta.1that produces constructor names over 2,400 characters long (e.g....MozInitialOrInheritOr...OrAliceblueOrAntiquewhiteOr...) — technically correct, but unusable, and it lands directly in the type surface app developers touch when overriding tokens.1.4.0-beta.2fixes this and one more thing along the way:mainbuild of bindgen (with the new name-freezing identity system) actually crashed with zero output on this exact blend version —SEARCH_INPUT's andMODAL'srangeDaytoken configs collide onto oneThemeProvider.rangeDayprojection, and the old code treated any such collision as a hard abort. It now degrades to a shape-disambiguated id and warns instead.@unboxedunion names are capped at 64 chars (readable prefix + shape hash) instead of enumerating every member. The 2,453-char name above is now 44 chars, e.g.mozInitialOrInheritOrInitialOrRevertEtc1mkx8.Verification
_REPORT.md: 235 components · 226 usable · 9 need review · 0 broken — identical component classification to chore(sync): regenerate bindings for @juspay/blend-design-system@0.0.38-beta.1 #144, same 9 components flagged for review, 0 fidelity loss (0 loosely-typed).TextArea's omitted-HTML-attributes type), down from 2,453+.npm run build→ 320 modules compiled, 0 errors.JsFn.res, no unreferenced shared-type modules; the one new module (ChartsSharedTypes.res) matches a documented SCC-merge dissolution, not a regression.Reviewer checklist
npm run buildis green (CI will block if not)src/_REPORT.mdshows 0 broken components; skim any flagged/loose props--set-version)🤖 Generated with Claude Code