Reformulation in final_touch#78
Open
blegat wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
===========================================
- Coverage 100.00% 99.69% -0.31%
===========================================
Files 12 12
Lines 636 656 +20
===========================================
+ Hits 636 654 +18
- Misses 0 2 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing #75, we got hit by jump-dev/MathOptInterface.jl#1980 - the order of calling
final_touchbetween ComplementsVectorizeBridge and VerticalBridge was wrong. So as a workaround, the reformulation were not done infinal_touch. This was working becauseSpecifySetTypeBridgebefore was doing the formulation infinal_touchso we know the bounds already got through. This is the kind of very brittle solution that Claude came up with ^^ Of course, everything would fall apart if a user would create aComplementsWithSetTypeconstraint directly and the bounds are passed after the bridge are created! So once jump-dev/MathOptInterface.jl#3025 lands, we can do things infinal_touchwhich is what this PR doesNeeds