Skip to content

Change ProductOfSets to remove dependence on implementation in MOI#372

Open
odow wants to merge 1 commit into
masterfrom
od/product-of-sets
Open

Change ProductOfSets to remove dependence on implementation in MOI#372
odow wants to merge 1 commit into
masterfrom
od/product-of-sets

Conversation

@odow

@odow odow commented Jul 17, 2026

Copy link
Copy Markdown
Member

I wanted to update MOI (jump-dev/MathOptInterface.jl#3022), but this part of DiffOpt depends on the internal fields.

The change to MOI is theoretically breaking (as evidenced by the need for this PR), so that is a draft for discussion. We might never merge the change in MOI, but this change could be merged regardless.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.26829% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.46%. Comparing base (f3fdbd8) to head (780b85c).

Files with missing lines Patch % Lines
src/product_of_sets.jl 78.75% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   91.88%   91.46%   -0.42%     
==========================================
  Files          17       17              
  Lines        2722     2788      +66     
==========================================
+ Hits         2501     2550      +49     
- Misses        221      238      +17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blegat

blegat commented Jul 17, 2026

Copy link
Copy Markdown
Member

Can the ProductOfSets in DiffOpt be simplified to be able to reuse against the implementation of the MOI one ? Actually, I always wanted to move this ProductOfSets of DiffOpt to MOI, it is also useful for MatrixOfConstraints and would be for any MOI model that can support arbitrary sets. Maybe we can move it to MOI first and then do jump-dev/MathOptInterface.jl#3022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants