Change ProductOfSets to remove dependence on implementation in MOI#372
Open
odow wants to merge 1 commit into
Open
Change ProductOfSets to remove dependence on implementation in MOI#372odow wants to merge 1 commit into
odow wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 91.88% 91.46% -0.42%
==========================================
Files 17 17
Lines 2722 2788 +66
==========================================
+ Hits 2501 2550 +49
- Misses 221 238 +17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Can the ProductOfSets in DiffOpt be simplified to be able to reuse against the implementation of the MOI one ? Actually, I always wanted to move this ProductOfSets of DiffOpt to MOI, it is also useful for MatrixOfConstraints and would be for any MOI model that can support arbitrary sets. Maybe we can move it to MOI first and then do jump-dev/MathOptInterface.jl#3022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to update MOI (jump-dev/MathOptInterface.jl#3022), but this part of DiffOpt depends on the internal fields.
The change to MOI is theoretically breaking (as evidenced by the need for this PR), so that is a draft for discussion. We might never merge the change in MOI, but this change could be merged regardless.