Conversation
Author
|
Closing this because the workspace-wide overrides force mbtiles 0.5 onto the sibling flutter_map_mbtiles package and break the repository's canonical CI. The repository-wide migration is already being handled in #121, so this partial migration would duplicate that work. Thanks. |
Owner
|
Thanks anyways for the pr @miakh - and for the pr on vector_map_tiles |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
vector_map_tiles_mbtiles1.2.1 says it supportsvector_map_tiles9, but a clean dependency solve still fails: the adapter pinsmbtiles0.4 /latlong20.9 while currentvector_map_tiles9 andflutter_map8.3 uselatlong20.10. This means the advertised upgrade path cannot currently be installed.We found this while upgrading a production Flutter app that uses online raster maps and offline MBTiles vector maps.
What changes
mbtiles ^0.5.1andlatlong2 ^0.10.1mbtiles0.5Verification
dart analyze --fatal-infos --fatal-warnings vector_map_tiles_mbtilesflutter test --no-pub vector_map_tiles_mbtiles/test -r compact(3 tests)Fixes #108