fix(build): use rm -rf so a clean first build doesn't fail#539
Conversation
On a fresh checkout there is no existing apps/finicky/build/Finicky.app, so the 'rm -r' under 'set -e' aborts the local build on its first run. Use 'rm -rf' so the removal is a no-op when the directory doesn't yet exist.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIn ChangesBuild Script Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
On a fresh checkout, running
./scripts/build.sh(local native-arch path) fails on its first run:The local build path does:
Because the script runs under
set -eandapps/finicky/build/Finicky.appdoes not exist yet on a first build,rm -rerrors out and aborts the build before themv/asset copy. It only works once a previous build has already created the directory.Fix
Use
rm -rfso the removal is a harmless no-op when the directory doesn't exist yet. Subsequent builds are unaffected.Testing
./scripts/install.sh && ./scripts/build.shnow completes withBuild complete ✨on the first run.Summary by CodeRabbit