refactor(gen-tm): deduplicate callee-token detection from #58#60
Merged
Conversation
…filter clause Post-merge cleanup for #58: the callee-token predicate was copy-pasted in the continuation-bracket call variant and the contextualScopes call-args region — extract findCalleeToken() so the two derived call regions cannot drift apart. Also removes the always-true `(o !== '(' || true)` leftover in the ctx-pair filter and fixes the mis-indented ctx-call-args entry. No behavior change: zero `npm run gen` drift, env-spec-regressions 28/28, highlighter gates 10/10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge cleanup of the code smells noted while reviewing #58 — no behavior change:
() was duplicated between the lineComment continuation-bracket call variant and the contextualScopesctx-call-argsregion. Extracted asfindCalleeToken()so the two derived call regions cannot drift apart.(o !== '(' || true)clause in the ctx-pair filter (always true; the(pair is excluded where it matters, at region emission).ctx-call-argsrepository entry.Validation
npx tsc --noEmitcleannpm run gen— zero drift across all built-in grammarsnode test/env-spec-regressions.ts— 28/28 (the Highlight fidelity for structured-comment dialects: lineComment regions, continuation brackets, contextualScopes, comment markup #58 behavioral spec)node test/check.ts highlighter— 10/10 gates