Skip to content

Keep plan review cards in document flow - #249

Open
LarryHu0217 wants to merge 2 commits into
johannesjo:mainfrom
LarryHu0217:codex/plan-review-comment-flow-214
Open

Keep plan review cards in document flow#249
LarryHu0217 wants to merge 2 commits into
johannesjo:mainfrom
LarryHu0217:codex/plan-review-comment-flow-214

Conversation

@LarryHu0217

@LarryHu0217 LarryHu0217 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • mount the pending input, review comments, and ask-code cards in flow slots after the selected plan block
  • preserve selection highlighting and sidebar scroll targeting while cleaning up slots on dismiss and unmount
  • anchor multi-block selections after their final block and handle list/table markup safely
  • start a fresh review session when the task, worktree, or plan content changes so stale slots and comments are not reused

Addresses the plan-review inline comment overlap item in #214.

Validation

  • npm test -- src/components/plan-review-flow.test.ts (3 passed)
  • npx vitest run src (65 files passed, 792 tests passed)
  • npm run check
  • npm run check:static
  • npm run build:frontend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant