fix: scroll StickySectionList tabs to measured section offsets - #194
Open
yerloveraaa wants to merge 1 commit into
Open
fix: scroll StickySectionList tabs to measured section offsets#194yerloveraaa wants to merge 1 commit into
yerloveraaa wants to merge 1 commit into
Conversation
Replace the SectionList + getItemLayout approach with an Animated.ScrollView that measures each section's real position via onLayout. Row heights were estimates, so tab presses landed in the wrong section and the render window left blank areas on screen. Index updates are blocked while a tab press travels to its target and released on arrival, so the tab strip animates once per press instead of once per section crossed. Also corrects the no-description/no-photo row height estimate in getItemLayout to match what ProductListItem renders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the SectionList + getItemLayout approach with an Animated.ScrollView that measures each section's real position via onLayout. Row heights were estimates, so tab presses landed in the wrong section and the render window left blank areas on screen.
Index updates are blocked while a tab press travels to its target and released on arrival, so the tab strip animates once per press instead of once per section crossed. Also corrects the no-description/no-photo row height estimate in getItemLayout to match what ProductListItem renders.