Fixes for enrollment packages expiration time - #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a secret field with copy/download to the lifecycle tab, and fixes the expiration display that always showed "expires now".
Problem
formatRelativereturned'just now'for future timestamps, soexpires ${formatRelative(futureDate)}rendered as "expires just now".Changes
Frontend — secret field (
frontend/src/features/enrollment/EnrollPage.tsx)SecretFieldcomponent in the Lifecycle tabGET /api/v1/environments/{env}/enroll/secretosctrl-{environment-name}.secretFrontend — expiration fix (
frontend/src/lib/time.ts)formatTimeUntil(iso)— returns"in 3d","in 2h","in 4m"for future datesformatRelativeto delegate future timestamps toformatTimeUntilinstead of returning'just now'LifecycleCardnow shows "expires in 3d" for future dates and "expired 2h ago" for past datesValidation
npm run check— TypeScript typecheck cleannpm test— 34 test files / 209 tests passgofmtclean on all modified files