fix: preserve PostgreSQL :: casts in Named queries#987
Open
leno23 wants to merge 2 commits into
Open
Conversation
Document issue/PR expectations and local test workflow for new contributors.
Fixes jmoiron#956 by treating :: after identifiers and after named parameters as PostgreSQL type casts instead of consuming a colon. Also covers :param::type patterns (e.g. jmoiron#983).
leno23
force-pushed
the
fix/named-postgres-cast-956
branch
from
621087d to
9e3a5ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #956
sqlx.Namedwas rewriting PostgreSQL type casts liket.path::texttot.path:text, breaking queries that use::for casts.::when it follows an identifier character (e.g.path::text)::when it follows a bound named parameter (e.g.:boundary::jsonb)appendBindvarhelperAlso adds regression tests for the #956 report and the
:param::typepattern from #983.Test plan
go test ./...TestNamedPostgresCastInIdentifierTestNamedPostgresCastAfterNamedParamTestCompileQueryexpectations for string literals containing::Made with Cursor